| From: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, "smithpb2250(at)gmail(dot)com" <smithpb2250(at)gmail(dot)com>, "david(dot)zhang(at)highgo(dot)ca" <david(dot)zhang(at)highgo(dot)ca>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Support tab completion for upper character inputs in psql |
| Date: | 2022-01-07 05:17:21 |
| Message-ID: | TYCPR01MB6128D4933189A74AAD326F98FB4D9@TYCPR01MB6128.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Friday, January 7, 2022 1:08 PM, Japin Li <japinli(at)hotmail(dot)com> wrote:
> +/*
> + * pg_string_tolower - Fold a string to lower case if the string is not quoted
> + * and only contains ASCII characters.
> + * For German/Turkish etc text, no change will be made.
> + *
> + * The returned value has to be freed.
> + */
> +static char *
> +pg_string_tolower_if_ascii(const char *text)
> +{
>
> s/pg_string_tolower/pg_string_tolower_if_ascii/ for comments.
>
Thanks for your review.
Comment fixed in the attached V11 patch.
Regards,
Tang
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-Support-tab-completion-with-a-query-result-for-u.patch | application/octet-stream | 7.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2022-01-07 05:18:30 | Re: Add 64-bit XIDs into PostgreSQL 15 |
| Previous Message | Michael Paquier | 2022-01-07 04:49:48 | pgsql: Refactor tar method of walmethods.c to rely on the compression m |