| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Peter Smith' <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Subject: | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Date: | 2023-09-01 04:46:18 |
| Message-ID: | TYAPR01MB5866CDC13CA9D6B9F4451606F5E4A@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Peter,
Thanks for giving comments! PSA new version.
I replied only comment 8 because others were replied by Amit.
> .../t/003_logical_replication_slots.pl
>
> 8. Consider adding one more test
>
> Maybe there should also be some "live check" test performed (e.g.
> using --check, and a running old_cluster).
>
> This would demonstrate pg_upgrade working successfully even when the
> WAL records are not consumed (because LSN checks would be skipped in
> check_old_cluster_for_valid_slots function).
I was ignored the case because it did not improve improve code coverage, but
indeed, no one has checked the feature. I'm still not sure what should be, but
added. I want to hear your opinions.
Furthermore, based on comments from Dilip [1], added the comment and
check_new_cluster_logical_replication_slots() was modified. IIUC pg_upgrade
does not have method to handle plural form, so if-statement was used.
If you have better options, please tell me.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v29-0001-Persist-logical-slots-to-disk-during-a-shutdown-.patch | application/octet-stream | 11.4 KB |
| v29-0002-pg_upgrade-Allow-to-replicate-logical-replicatio.patch | application/octet-stream | 34.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2023-09-01 04:47:19 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Previous Message | Amit Kapila | 2023-09-01 04:36:37 | Re: persist logical slots to disk during shutdown checkpoint |