| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Katsuragi Yuta' <katsuragiy(at)oss(dot)nttdata(dot)com> |
| Cc: | 'Ted Yu' <yuzhihong(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, vignesh C <vignesh21(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com" <Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | RE: [Proposal] Add foreign-server health checks infrastructure |
| Date: | 2023-01-25 11:07:16 |
| Message-ID: | TYAPR01MB5866969DBAEEEC5AE07591BFF5CE9@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Katsuragi-san,
Thank you for reading the patch! PSA new version.
> Thank you for updating the patch!
>
> +/* Check whether the postgres server is still alive or not */
> +extern int PQConnCheck(PGconn *conn);
> +extern int PQCanConnCheck(void);
>
> Aren't these PQconnCheck and PQcanConnCheck? I think the first letter
> following 'PQ' should be lower case.
I cannot find any rules about it, but seems right. Fixed.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v27-0001-Add-PQconnCheck-and-PQcanConnCheck-to-libpq.patch | application/octet-stream | 5.0 KB |
| v27-0002-postgres_fdw-add-postgres_fdw_verify_connection_.patch | application/octet-stream | 11.1 KB |
| v27-0003-add-test.patch | application/octet-stream | 4.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2023-01-25 11:21:11 | Re: to_hex() for negative inputs |
| Previous Message | Aleksander Alekseev | 2023-01-25 10:57:43 | Re: to_hex() for negative inputs |