| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Ted Yu' <yuzhihong(at)gmail(dot)com> |
| Cc: | Katsuragi Yuta <katsuragiy(at)oss(dot)nttdata(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, vignesh C <vignesh21(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com" <Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | RE: [Proposal] Add foreign-server health checks infrastructure |
| Date: | 2023-01-23 05:40:34 |
| Message-ID: | TYAPR01MB58668DD17F19CAFC97A3134EF5C89@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Ted,
Thanks for reviewing! PSA new version.
> For v25-0001-Add-PQConnCheck-and-PQCanConnCheck-to-libpq.patch , `pqConnCheck_internal` only has one caller which is quite short.
> Can pqConnCheck_internal and PQConnCheck be merged into one func ?
I divided the function for feature expandability. Currently it works on linux platform,
but the limitation should be removed in future and internal function will be longer.
Therefore I want to keep this style.
> +int
> +PQCanConnCheck(void)
>
> It seems the return value should be of bool type.
I slightly changed the returned value like true/false. But IIUC libpq functions
cannot define as "bool" datatype. E.g. PQconnectionNeedsPassword() returns true/false,
but the function is defined as int.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v26-0001-Add-PQConnCheck-and-PQCanConnCheck-to-libpq.patch | application/octet-stream | 5.0 KB |
| v26-0002-postgres_fdw-add-postgres_fdw_verify_connection_.patch | application/octet-stream | 11.1 KB |
| v26-0003-add-test.patch | application/octet-stream | 4.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2023-01-23 05:58:21 | Re: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | Dilip Kumar | 2023-01-23 05:39:14 | Re: Exit walsender before confirming remote flush in logical replication |