| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Dilip Kumar' <dilipbalaut(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | RE: Exit walsender before confirming remote flush in logical replication |
| Date: | 2022-12-27 08:14:13 |
| Message-ID: | TYAPR01MB5866580E59386FF24B41E94FF5ED9@TYAPR01MB5866.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Dilip,
Thanks for checking my proposal!
> - * Note that if we determine that there's still more data to send, this
> - * function will return control to the caller.
> + * Note that if we determine that there's still more data to send or we are in
> + * the physical replication more, this function will return control to the
> + * caller.
>
> I think in this comment you meant to say
>
> 1. "or we are in physical replication mode and all WALs are not yet replicated"
> 2. Typo /replication more/replication mode
Firstly I considered 2, but I thought 1 seemed to be better.
PSA the updated patch.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Exit-walsender-before-confirming-remote-flush-in-.patch | application/octet-stream | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2022-12-27 08:27:49 | Re: Making Vars outer-join aware |
| Previous Message | Pavel Stehule | 2022-12-27 07:48:11 | Re: Parallel Aggregates for string_agg and array_agg |