RE: Allow escape in application_name

From: "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Kyotaro Horiguchi' <horikyota(dot)ntt(at)gmail(dot)com>
Cc: "masao(dot)fujii(at)oss(dot)nttdata(dot)com" <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "ikedamsh(at)oss(dot)nttdata(dot)com" <ikedamsh(at)oss(dot)nttdata(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: RE: Allow escape in application_name
Date: 2021-10-15 08:45:10
Message-ID: TYAPR01MB58664445FE79A24D5AA1F857F5B99@TYAPR01MB5866.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Horiguchi-san,

> I'm not sure. All of it is a if-story. z/OS's isdigit is defined as
> "Test for a decimal digit, as defined in the digit locale source file
> and in the digit class of the LC_CTYPE category of the current
> locale.", which I read it as "it accepts multibyte strings" but of
> course I'm not sure that's correct.
>
> On CentOS8, and for Japanese letters, both iswdigit(L'ー') and
> iswdigit(L'0') return false so, assuming the same character
> classfication scheme that is implementation dependent, I guess z/OS's
> isdigit would behave the same way with CentOS's isdigit.
>
> Hoever, regardless of the precise behavior,
>
> > But, of cause I agreed this is the crazy case.
>
> Yes, I meant that that doesn't matter.

Hmm.. of cause I want to do because I believe this is corner case,
but we should avoid regression...
If no one can say it completely some existing methods probably should be used.
Therefore, I would like to suggest using the export and support functions again.
The name is converted to parse_XXX and it locates in elog.c. How is it?

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

Attachment Content-Type Size
v20_0002_allow_escapes.patch application/octet-stream 10.8 KB
v20_0001_export_padding_function.patch application/octet-stream 2.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ken Kato 2021-10-15 08:49:43 Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion
Previous Message Amit Langote 2021-10-15 08:38:31 Re: Multi-Column List Partitioning