| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: [PATCH] Support automatic sequence replication |
| Date: | 2026-03-02 07:58:54 |
| Message-ID: | TY4PR01MB1690715895CDE6FEFA13C2A2C947EA@TY4PR01MB16907.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Saturday, February 28, 2026 4:41 PM Zhijie Hou (Fujitsu) <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> Here is the V8 patch set addressing the previous review comments:
>
> - For 0001, I noticed that the GetSequence() function added in the patch
> fetches the local sequence value without any privilege check. This
> allows the worker to read sequence data even without proper SELECT
> privilege, which seems unsafe. I've added a SELECT privilege check
> before fetching the sequence value. Additionally, I've updated several
> comments, made cosmetic changes, commit message update, and run
> pgindent on all patches.
>
> - 0002 includes the changes to synchronize sequences directly in the
> REFRESH SEQUENCES command
Rebased the patch to silence compile warning due to a recent commit
a2c89835.
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0002-Synchronize-sequences-directly-in-REFRESH-SEQUENC.patch | application/octet-stream | 17.2 KB |
| v9-0001-Support-automatic-sequence-replication.patch | application/octet-stream | 41.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2026-03-02 08:01:05 | Re: pg_stat_io_histogram |
| Previous Message | Amit Langote | 2026-03-02 07:49:05 | Re: Eliminating SPI / SQL from some RI triggers - take 3 |