RE: Improve logging when using Huge Pages

From: "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: "rjuju123(at)gmail(dot)com" <rjuju123(at)gmail(dot)com>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "Justin Pryzby" <pryzby(at)telsasoft(dot)com>
Subject: RE: Improve logging when using Huge Pages
Date: 2021-11-02 09:31:33
Message-ID: TU4PR8401MB11527AEB859A4C70F060EC65EE8B9@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii-san, Sawada-san,

Thank you for your comment.

> Also, with the patch, the log message is emitted also during initdb and starting up in single user mode:

Certainly the log output when executing the initdb command was a noise.
The attached patch reflects the comments and uses IsPostmasterEnvironment to suppress the output message.

Regards,
Noriyoshi Shinoda

-----Original Message-----
From: Fujii Masao [mailto:masao(dot)fujii(at)oss(dot)nttdata(dot)com]
Sent: Tuesday, November 2, 2021 1:25 AM
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>; Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi(dot)shinoda(at)hpe(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org; rjuju123(at)gmail(dot)com; tgl(at)sss(dot)pgh(dot)pa(dot)us; Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>; Justin Pryzby <pryzby(at)telsasoft(dot)com>
Subject: Re: Improve logging when using Huge Pages

On 2021/10/29 16:00, Masahiko Sawada wrote:
> Which is noisy. Perhaps it's better to log it only when
> IsPostmasterEnvironment is true.

+1

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment Content-Type Size
huge_pages_log_v8.diff application/octet-stream 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message tanghy.fnst@fujitsu.com 2021-11-02 09:45:27 RE: Skipping logical replication transactions on subscriber side
Previous Message Amit Kapila 2021-11-02 09:27:28 Re: parallel vacuum comments