Skip site navigation (1) Skip section navigation (2)

Re: Bunch of tsearch fixes and cleanup

From: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Patches <pgsql-patches(at)postgresql(dot)org>, Teodor Sigaev <teodor(at)sigaev(dot)ru>
Subject: Re: Bunch of tsearch fixes and cleanup
Date: 2007-08-23 17:54:29
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
On Thu, 23 Aug 2007, Tom Lane wrote:

> "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> writes:
>> - readstopwords calls recode_and_lowerstr directly, instead of using the
>>  "wordop" function pointer in StopList struct. All callers used
>> recode_and_lowerstr anyway, so this simplifies the code a little bit. Is
>> there any external dictionary implementations that would require
>> different behavior?
> I don't think eliminating wordop altogether is such a hot idea; some
> dictionary could possibly want to do different processing than that.
> Something that was annoying me yesterday was that it was not clear
> whether we had fixed every single place that uses a tsearch config file
> to assume that the file is in UTF8 and should be converted to database
> encoding.  So I was thinking of hardwiring the "recode" part into
> readstopwords, and using wordop just for the "lowercase" part, which
> seemed to me like a saner division of labor.  That is, UTF8 is a policy
> that we want to enforce globally, but lowercasing maybe not, and this
> still leaves the door open for more processing besides lowercasing.
> Oleg, Teodor, what do you think about this?

I agrre with utf-8 recoding and please, don't lowercase. Dictionaries
are very different.

> 			regards, tom lane

Oleg Bartunov, Research Scientist, Head of AstroNet (,
Sternberg Astronomical Institute, Moscow University, Russia
Internet: oleg(at)sai(dot)msu(dot)su,
phone: +007(495)939-16-83, +007(495)939-23-83

In response to

pgsql-patches by date

Next:From: Zdenek KotalaDate: 2007-08-23 19:50:01
Subject: Re: pg_ctl configurable timeout
Previous:From: Tom LaneDate: 2007-08-23 16:17:23
Subject: Re: BUG #3571: call to decrypt causes segfault

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group