Re: Updated ALTER TABLE ... SET TABLESPACE patch

On Thu, 1 Jul 2004, Gavin Sherry wrote:

> Hi all,
>
> Attached is an updated ALTER TABLE ... SET TABLESPACE patch.
>
> It uses the block by block copy mechanism proposed by Tom and handles i)
> ALTER TABLE <index> .... and ii) Copying of TOAST tables and the TOAST
> table's index.
>
> It doesn't handle copying of system tables (pg_largeobject) and, in the
> interests of code reuse, the patch fiddles with the code used by CLUSTER.
> This isn't great but I wanted to get a patch in before 1 July since I
> think the feature is very important -- even for the first release.

Oh, and it doesn't handle WAL. Tom mentioned/agreed that btree's method of
dumping whole pages into WAL would be the best/most efficient way to
journaling this and that the btree code should be generalised. I haven't
had time to look at this yet.

>
> Thanks,
>
> Gavin