Re: ALTER TABLE TODO items

From: "scott(dot)marlowe" <scott(dot)marlowe(at)ihs(dot)com>
To: Richard Huxton <dev(at)archonet(dot)com>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER TABLE TODO items
Date: 2004-05-06 15:47:13
Message-ID: Pine.LNX.4.33.0405060946080.4971-100000@css120.ihs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, 6 May 2004, Richard Huxton wrote:

> Bruce Momjian wrote:
> > Tom Lane wrote:
> >
> >>Richard Huxton <dev(at)archonet(dot)com> writes:
> >>
> >>>Does that mean I'll want to disable triggers while I do this?
> >>
> >>Hrm. Right now the code does not fire triggers at all, but that seems
> >>wrong. However, I doubt that very many triggers could cope with update
> >>events in which the old and new rows have different rowtypes :-(.
> >>Any thoughts what to do about that?
> >
> >
> > If triggers exist, I think we should just throw a warning that triggers
> > will not be fired.
>
> Tom's point about triggers probably not working after the upgrade is a
> good one though. Is it reasonable to just refuse to act on a table until
> all triggers are dropped? I'd rather be forced to go through and
> drop/restore triggers in a script than be surprised later on.

How about "cascade drop triggers" as an option so you can still do it in
one line should you want to?

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2004-05-06 16:10:57 pgsql-server/src backend/commands/cluster.c ba ...
Previous Message Tom Lane 2004-05-06 14:01:33 pgsql-server/src backend/nodes/outfuncs.c back ...

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2004-05-06 15:55:29 alter table alter columns vs. domains
Previous Message sdv mailer 2004-05-06 15:30:01 Re: PostgreSQL pre-fork speedup