Skip site navigation (1) Skip section navigation (2)

Re: More fixes for missing double quotes in the shell

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Justin <justin(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Patches Mailing List <pgsql-patches(at)postgresql(dot)org>
Subject: Re: More fixes for missing double quotes in the shell
Date: 2001-09-29 22:53:54
Message-ID: Pine.LNX.4.30.0109300025190.629-100000@peter.localdomain (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
Justin writes:

> I agree it's not strictly necessary, but I thought I'd add them in to
> follow the generic "good programming practise" of always quoting
> variables in shell script tests.

In my purely personal opinion it's better to be aware of the possible
values of a variable than to blindly quote everything.  Somewhere you're
going to run into nested quote situations which cannot be done portably,
at which point you have to start doing that anyway.

Peter Eisentraut   peter_e(at)gmx(dot)net

In response to


pgsql-patches by date

Next:From: Peter EisentrautDate: 2001-09-29 22:54:53
Subject: Re: Trailing semicolons in psql patch
Previous:From: Tom LaneDate: 2001-09-29 20:15:01
Subject: Re: Problem with setlocale (found in libecpg) [accessing a memory location after freeing it]

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group