Ian Lance Taylor writes:
> Note that this patch normally will not run prep_buildtree on top of
> the source tree. That would only happen in exceptional circumstances
> in which /bin/pwd did not return the same string in the same
> directory. I wrote the patch to address Tom Lane's suggestion of not
> requiring test to support the relatively new -ef option.
I've thought hard about this and the solution that satisfied me most was
test $srcdir -ef . || test `cd $srcdir && /bin/pwd` = `/bin/pwd`
(properly quoted etc.) means srcdir == builddir. That means on Solaris
you will invoke the second part, as you suggested in your patch, whereas
if test -ef works you'll get the safer alternative.
I've also installed your prep_buildtree patch to be on the safe side.
One of my concerns is that prep_buildtree isn't super-portable by design
(using 'find'), but we'll just have to cross our fingers that nobody
exercises all these unlikely cases.
Peter Eisentraut peter_e(at)gmx(dot)net http://funkturm.homeip.net/~peter
In response to
pgsql-patches by date
|Next:||From: Kenji Sugita||Date: 2001-09-11 00:20:33|
|Subject: Re: Configuring fdatasync for Solaris2|
|Previous:||From: Jeroen van Vianen||Date: 2001-09-10 18:00:39|
|Subject: Fix for broken JDBC's getColumn() (take 2)|