Re: [GENERAL] Patch (tiny): \cd (change dir) for psql [with feedback]

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Mark Hamby <mark(at)archer(dot)leavenworth(dot)army(dot)mil>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [GENERAL] Patch (tiny): \cd (change dir) for psql [with feedback]
Date: 2001-03-26 20:04:13
Message-ID: Pine.LNX.4.30.0103262200100.1114-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-patches

Mark Hamby writes:

> Here's a patch for a \cd (change dir) command in psql program.
> It's very small and only adds a few lines.
> Personally, I am surprised psql does not have this command.
> It is EXTREMELY useful when \include'ing SQL scripts to set
> up a database schema.

This sounds like a good idea.

Problems with your patch:

1. You can't portably use getcwd(NULL, xxx).

2. You should test for !quiet before printing messages to stdout.

3. You should use scan_option() to read command arguments. See \connect
above your code (rather than \copy below).

Unless you manage to fix these issues, I will do it. :-)

--
Peter Eisentraut peter_e(at)gmx(dot)net http://yi.org/peter-e/

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Scott Gritton 2001-03-26 20:21:55 Starting Postmaster
Previous Message Mark Hamby 2001-03-26 20:04:03 Patch (tiny): \cd (change dir) for psql [with feedback]

Browse pgsql-patches by date

  From Date Subject
Next Message Lee Harr 2001-03-27 00:09:35 Re: Patch (tiny): \cd (change dir) for psql.
Previous Message Mark Hamby 2001-03-26 20:04:03 Patch (tiny): \cd (change dir) for psql [with feedback]