Re: backend crashing despite tsearch2 patch

This replaces the previous patch in this thread.

On Wed, 17 Sep 2003, Nigel J. Andrews wrote:
>
> On Wed, 17 Sep 2003 psql-mail(at)freeuk(dot)com wrote:
>
> > > On Wed, 17 Sep 2003 psql-mail(at)freeuk(dot)com wrote:
> > >
> > > > #0 SN_create_env (S_size=0, I_size=2, B_size=1) at api.c:6
> > > > 6 z->p = create_s();
> > > > (gdb) bt
> > > > #0 SN_create_env (S_size=0, I_size=2, B_size=1) at api.c:6
> > > > #1 0x20000000026be870 in SN_create_env (S_size=40770504, I_size=
> > > > 40509856,
> > > > B_size=1034) at api.c:6
> > >
> ...
> Having said that the z in the z->p = create_s() line mentioned as the place of
> the fault is the result of a calloc without checking for a null return from
> calloc. Here's a[nother simple] patch to fix that.
>
> It's not going to fix whatever is putting you into the situation that makes
> calloc fail though. It'll just make the failure less disasterous.

Here's a slightly more paranoid patch, i.e. it checks all the allocations done
in the routine instead of just the specific instance from the stack trace the
previous patch checked.

On a matter of style, it's been a while since I've seriously considered cross
platform C. Is it the done thing to expect:

int *i = (int *)calloc(1,sizeof(int));

to give the condition *i == 0 (assuming the memory allocation worked)?

Also, I've not tested the amended code since I don't know that much about the
configuration of tsearch2 and specifically what this snowball stuff
is. However, it builds for me and a test query didn't break. I'd appreciate if
someone could give the changes a quick once over for correctness and if someone
could actually test this (maybe pgsql-mail(at)freeuk(dot)com). In the meantime I'll
see if I can get the regression test to run.

--
Nigel J. Andrews