On Tue, 27 Feb 2001, Tom Lane wrote:
> > He's moved the "static globals" from around line 286 of
> > src/backend/access/transam/xlog.c:
> > to be static locals inside of function ReadRecord around line 1216 in the
> > same file:
> This is not usual coding practice in Postgres, so far as I've noticed.
> I prefer to avoid static locals because the fact that they *are*
> static is easily missed. In particular it's way too easy to misread
> the initialization as something that happens on every entry to the
> function, rather than only once. So my opinion is that this change is
> bad style.
Fair enough. I just found it even more confusing that they were
defined almost 1KLOC from their only use.
But functions of 300LOC tend to fail my taste guidelines too, so
perhaps I should leave well alone :)
In response to
pgsql-patches by date
|Next:||From: Matthew Kirkwood||Date: 2001-02-27 22:20:57|
|Subject: Re: mmap for zeroing WAL log|
|Previous:||From: Bruce Momjian||Date: 2001-02-27 20:55:21|
|Subject: Re: Small xlog.c cleanup|