| From: | Boris Mironov <boris_mironov(at)outlook(dot)com> |
|---|---|
| To: | Madyshev Egor <E(dot)Madyshev(at)ftdata(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Idea to enhance pgbench by more modes to generate data (multi-TXNs, UNNEST, COPY BINARY) |
| Date: | 2026-03-03 11:13:01 |
| Message-ID: | PH0PR08MB702059923096E4BAA78FED02887FA@PH0PR08MB7020.namprd08.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Egor,
Sorry for so many extra changes. I promise, this one is good.
I believe it will beneficial to explain how buffer size for each row in COPY BINARY is actually calculated. Instead of hard coded values like 35, 40, 250, I put in comments actual sizes of each field as well as easy to read formulas. IMHO it adds extra value and resolves possible future questions right away.
I greatly appreciate your time spent on this patch.
Best regards,
Boris
| Attachment | Content-Type | Size |
|---|---|---|
| v11-pgbench-faster-modes.patch | application/octet-stream | 133.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan Gonzalez V. | 2026-03-03 11:15:03 | Re: [oauth] Add TLS support to OAuth tests |
| Previous Message | Jaroslav Novikov | 2026-03-03 10:43:13 | Re: Streaming replication and WAL archive interactions |