RE: Logical Replication of sequences

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'vignesh C' <vignesh21(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Subject: RE: Logical Replication of sequences
Date: 2025-10-14 03:13:15
Message-ID: OSCPR01MB149667963060BB6A068B275B9F5EBA@OSCPR01MB14966.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Vignesh,

Thanks for updating the patch. Here are comments for 0002.

```
+ if (pubrelkind == '\0')
+ return;
```

Instead of adding this part, can we provide another function which only checks
the type mismatch? New one can be called from CreateSubscription() and
AlterSubscription_refresh().

```
+#include "nodes/primnodes.h"
...
+typedef struct SubscriptionRelKind
+{
+ RangeVar *rv;
+ char relkind;
+}
```

The data structure is used in subscriptioncmds.c. Can we move the definition to
the file?
Also, `relkind` indicates the type of relation on publisher. Can you clarify
the point like `relkind_on_pub`?

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirill Reshke 2025-10-14 03:31:04 Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)
Previous Message Tom Lane 2025-10-14 02:44:45 Re: [PING] [PATCH v2] parallel pg_restore: avoid disk seeks when jumping short distance forward