| From: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com> |
|---|---|
| To: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, 'Masahiko Sawada' <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "masao(dot)fujii(at)oss(dot)nttdata(dot)com" <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "laurenz(dot)albe(at)cybertec(dot)at" <laurenz(dot)albe(at)cybertec(dot)at>, "ashutosh(dot)bapat(dot)oss(at)gmail(dot)com" <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Disable WAL logging to speed up data loading |
| Date: | 2021-01-12 03:13:53 |
| Message-ID: | OSBPR01MB4888D32F5C2FC504FA54635AEDAA0@OSBPR01MB4888.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
On Mon, Jan 11, 2021 9:14 AM Tsunakawa, Takayuki <tsunakawa(dot)takay(at)fujitsu(dot)com> wrote:
> From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
> > I think it's better to have index AM (and perhaps table AM) control it
> > instead of filtering in XLogInsert(). Because otherwise third-party
> > access methods that use LSN like gist indexes cannot write WAL records
> > at all when wal_level = none even if they want.
>
> Hm, third-party extensions use RM_GENERIC_ID, so it should probably be
> allowed in XLogInsert() as well instead of allowing control in some other way.
> It's not unnatural that WAL records for in-core AMs are filtered in XLogInsert().
I updated the patch following this discussion,
and fixed the documentation as well.
No failure is found during make check-world.
Best Regards,
Takamichi Osumi
| Attachment | Content-Type | Size |
|---|---|---|
| disable_WAL_logging_v06.patch | application/octet-stream | 14.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-01-12 03:19:53 | Re: [Patch] Optimize dropping of relation buffers using dlist |
| Previous Message | tsunakawa.takay@fujitsu.com | 2021-01-12 03:04:54 | RE: POC: postgres_fdw insert batching |