| From: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com> |
|---|---|
| To: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
| Cc: | 'Masahiko Sawada' <sawada(dot)mshk(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "masao(dot)fujii(at)oss(dot)nttdata(dot)com" <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "laurenz(dot)albe(at)cybertec(dot)at" <laurenz(dot)albe(at)cybertec(dot)at>, "ashutosh(dot)bapat(dot)oss(at)gmail(dot)com" <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Disable WAL logging to speed up data loading |
| Date: | 2021-01-12 07:09:28 |
| Message-ID: | OSBPR01MB488874AED9551DB4FAFEC0B5EDAA0@OSBPR01MB4888.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday, January 12, 2021 12:52 PM Takayuki/綱川 貴之 <tsunakawa(dot)takay(at)fujitsu(dot)com> wrote:
> From: Osumi, Takamichi/大墨 昂道 <osumi(dot)takamichi(at)fujitsu(dot)com>
> > I updated the patch following this discussion, and fixed the
> > documentation as well.
>
>
> + (rmid == RM_GIST_ID && info == RM_GIST_ID) ||
> + (rmid == RM_GENERIC_ID)))
>
> info is wrong for GiST, and one pair of parenthesis is unnecessary. The above
> would be:
>
> + (rmid == RM_GIST_ID && info ==
> XLOG_GIST_ASSIGN_LSN) ||
> + rmid == RM_GENERIC_ID))
Oops, sorry for this careless mistake.
Fixed. And again, regression test produces no failure.
Best Regards,
Takamichi Osumi
| Attachment | Content-Type | Size |
|---|---|---|
| disable_WAL_logging_v07.patch | application/octet-stream | 14.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-01-12 07:18:24 | Re: Reduce the number of special cases to build contrib modules on windows |
| Previous Message | Bharath Rupireddy | 2021-01-12 06:47:20 | Fix a typo in SearchCatCache function comment |