| From: | "nagaura(dot)ryohei(at)fujitsu(dot)com" <nagaura(dot)ryohei(at)fujitsu(dot)com> |
|---|---|
| To: | 'Michael Paquier' <michael(at)paquier(dot)xyz> |
| Cc: | "'pgsql-hackers(at)postgresql(dot)org'" <pgsql-hackers(at)postgresql(dot)org>, "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com>, 'Fabien COELHO' <coelho(at)cri(dot)ensmp(dot)fr>, 'Kyotaro HORIGUCHI' <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, "'robertmhaas(at)gmail(dot)com'" <robertmhaas(at)gmail(dot)com>, "MikalaiKeida(at)ibagroup(dot)eu" <MikalaiKeida(at)ibagroup(dot)eu>, "AYahorau(at)ibagroup(dot)eu" <AYahorau(at)ibagroup(dot)eu>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
| Subject: | RE: [patch]socket_timeout in interfaces/libpq |
| Date: | 2019-11-29 05:22:01 |
| Message-ID: | OSBPR01MB4534F90FC45BE71A479E243996460@OSBPR01MB4534.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Michael-san.
Sorry, I have missed your e-mail...
> From: Michael Paquier <michael(at)paquier(dot)xyz>
> On Wed, Jun 26, 2019 at 11:56:28AM +0000, nagaura(dot)ryohei(at)fujitsu(dot)com wrote:
> > It seems that you did not think so at that time.
> > # Please refer to [1]
> >
> > I don't think all the reviewers are completely negative.
>
> I recall having a negative impression on the patch when first looking at it, and still
> have the same impression when looking at the last version. Just with a quick
> look, assuming that you can bypass all cleanup operations normally taken by
> pqDropConnection() through a hijacking of pqWait() is not fine as this routine
> explicitely assumes to *never* have a timeout for its wait.
I couldn't understand what you meant.
Do you say that we shouldn't change pqWait() behavior?
Or should I modify my patch to use pqDropConnection()?
Best regards,
---------------------
Ryohei Nagaura
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2019-11-29 05:39:57 | A rather hackish POC for alternative implementation of WITH TIES |
| Previous Message | Andrew Gierth | 2019-11-29 05:19:00 | Re: FETCH FIRST clause WITH TIES option |