RE: Incorrect CONTEXT reported for errors from parallel apply worker in logical replication

Hi Vignesh,

Thanks for the review!

> Thanks for the updated patch.
> Few minor suggestions:
> 1) apply_error_context_stack used to mean "the stack including
> apply_error_callback", and with this patch it deliberately means the
> opposite. The name now says the reverse of what the variable holds.
> How about renaming it to apply_loop_outer_error_context_stack or a
> better one if you have, and adding a short comment at the definition
> saying that it is the stack before LogicalRepApplyLoop() pushed
> apply_error_callback, and that parallel apply worker errors are
> reported with it?

Indeed, replaced to apply_loop_outer_error_context_stack. Code comments were
added atop the declaration, so a comment in LogicalRepApplyLoop is adjusted (reduced).

> 2) The patch reverses the choice made in 216a784829c, which states:
> "Context beyond that should use the error context callbacks that were
> in effect in LogicalRepApplyLoop()". The reasoning for this change is
> sound. Could the commit message explicitly mention that it changes the
> earlier choice and explain why?

+1, but adjusted on my side. The commit id should be clarified at second paragraph,
and changes are clarified at the end.
I checked sentences via Grammarly.

Best regards,
Hayato Kuroda
FUJITSU LIMITED