From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
---|---|
To: | 'Euler Taveira' <euler(at)eulerto(dot)com> |
Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
Subject: | RE: speed up a logical replica setup |
Date: | 2024-02-08 14:22:21 |
Message-ID: | OS7PR01MB1208165855BEC7A197C58B2D1F5442@OS7PR01MB12081.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dear Euler,
Here are my minor comments for 17.
01.
```
/* Options */
static const char *progname;
static char *primary_slot_name = NULL;
static bool dry_run = false;
static bool success = false;
static LogicalRepInfo *dbinfo;
static int num_dbs = 0;
```
The comment seems out-of-date. There is only one option.
02. check_subscriber and check_publisher
Missing pg_catalog prefix in some lines.
03. get_base_conninfo
I think dbname would not be set. IIUC, dbname should be a pointer of the pointer.
04.
I check the coverage and found two functions have been never called:
- drop_subscription
- drop_replication_slot
Also, some cases were not tested. Below bullet showed notable ones for me.
(Some of them would not be needed based on discussions)
* -r is specified
* -t is specified
* -P option contains dbname
* -d is not specified
* GUC settings are wrong
* primary_slot_name is specified on the standby
* standby server is not working
In feature level, we may able to check the server log is surely removed in case
of success.
So, which tests should be added? drop_subscription() is called only when the
cleanup phase, so it may be difficult to test. According to others, it seems that
-r and -t are not tested. GUC-settings have many test cases so not sure they
should be. Based on this, others can be tested.
PSA my top-up patch set.
V18-0001: same as your patch, v17-0001.
V18-0002: modify the alignment of codes.
V18-0003: change an argument of get_base_conninfo. Per comment 3.
=== experimental patches ===
V18-0004: Add testcases per comment 4.
V18-0005: Remove -P option. I'm not sure it should be needed, but I made just in case.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/global/
Attachment | Content-Type | Size |
---|---|---|
v18-0001-Creates-a-new-logical-replica-from-a-standby-ser.patch | application/octet-stream | 78.0 KB |
v18-0002-Follow-coding-conversions.patch | application/octet-stream | 42.2 KB |
v18-0003-Fix-argument-for-get_base_conninfo.patch | application/octet-stream | 1.8 KB |
v18-0004-Add-testcase.patch | application/octet-stream | 3.8 KB |
v18-0005-Remove-P-and-use-primary_conninfo-instead.patch | application/octet-stream | 12.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Ilia Evdokimov | 2024-02-08 14:24:06 | Re: pg_stat_advisor extension |
Previous Message | Daniel Gustafsson | 2024-02-08 14:16:07 | Re: Reducing connection overhead in pg_upgrade compat check phase |