| From: | "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Fix the description of GUC "max_locks_per_transaction" and "max_pred_locks_per_transaction" in guc_table.c |
| Date: | 2023-02-15 08:16:43 |
| Message-ID: | OS3PR01MB6275BDD09C9B875C65FCC5AB9EA39@OS3PR01MB6275.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
When I refer to the GUC "max_locks_per_transaction", I find that the description
of the shared lock table size in pg-doc[1] is inconsistent with the code
(guc_table.c). BTW, the GUC "max_predicate_locks_per_xact" has similar problems.
I think the descriptions in pg-doc are correct.
- GUC "max_locks_per_transaction"
Please refer to the macro "NLOCKENTS" used to obtain max_table_size in the
function InitLocks.
- GUC "max_predicate_locks_per_xact"
Please refer to the macro "NPREDICATELOCKTARGETENTS" used to obtain
max_table_size in the function InitPredicateLocks.
Attach the patch to fix the descriptions of these two GUCs in guc_table.c.
[1] - https://www.postgresql.org/docs/devel/runtime-config-locks.html
Regards,
Wang Wei
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-the-description-of-GUC-max_locks_per_trans.patch | application/octet-stream | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2023-02-15 08:21:48 | Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry |
| Previous Message | John Naylor | 2023-02-15 08:03:22 | Re: Todo: Teach planner to evaluate multiple windows in the optimal order |