| From: | "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Fabrice Chapuis <fabrice636861(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Subject: | RE: Rework LogicalOutputPluginWriterUpdateProgress |
| Date: | 2023-03-06 10:18:18 |
| Message-ID: | OS3PR01MB6275482D88E78CC90D77D38B9EB69@OS3PR01MB6275.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 3, 2023 8:18 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
Thanks for your comments.
> 1.
> +
> +static void UpdateProgressAndKeepalive(LogicalDecodingContext *ctx,
> + bool finished_xact);
> +
> +static bool is_keepalive_threshold_exceeded(LogicalDecodingContext *ctx);
>
> 1a.
> There is an unnecessary extra blank line above the UpdateProgressAndKeepalive.
Removed.
> ~
>
> 1b.
> I did not recognize a reason for the different naming conventions.
> Here are two new functions but one is CamelCase and one is snake_case.
> What are the rules to decide the naming?
I used the snake_case style for the function UpdateProgressAndKeepalive in the
previous version, but it was confusing because it shared the same parameter name
with the functions StartupDecodingContext, CreateInitDecodingContext and
CreateDecodingContext. To avoid this confusion, and since both naming styles
exist in this file, I changed it to CamelCase style.
Attach the new patch.
Regards,
Wang wei
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Rework-LogicalOutputPluginWriterUpdateProgress.patch | application/octet-stream | 40.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-03-06 10:44:24 | Re: Deduplicate logicalrep_read_tuple() |
| Previous Message | wangw.fnst@fujitsu.com | 2023-03-06 10:16:59 | RE: Support logical replication of DDLs |