| From: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, David Zhang <david(dot)zhang(at)highgo(dot)ca>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Support tab completion for upper character inputs in psql |
| Date: | 2021-04-14 13:34:11 |
| Message-ID: | OS0PR01MB611303B647967B6949B759F1FB4E9@OS0PR01MB6113.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thursday, April 8, 2021 4:14 PM, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote
>Seeing the tests you provided, it's pretty obvious that the current
>behavior is insufficient. I think we could probably think of a few more
>tests, for example exercising the "If case insensitive matching was
>requested initially, adjust the case according to setting." case, or
>something with quoted identifiers.
Thanks for your review and suggestions on my patch.
I've added more tests in the latest patch V5, the added tests helped me find some bugs in my patch and I fixed them.
Now the patch can support not only the SET/SHOW [PARAMETER] but also UPDATE ["aTable"|ATABLE], also UPDATE atable SET ["aColumn"|ACOLUMN].
I really hope someone can have more tests suggestions on my patch or kindly do some tests on my patch and share me if any bugs happened.
Differences from V4 are:
* fix some bugs related to quoted identifiers.
* add some tap tests.
Regards,
Tang
| Attachment | Content-Type | Size |
|---|---|---|
| V5-0001-Support-tab-completion-with-a-query-result-for-upper.patch | application/octet-stream | 7.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-04-14 13:46:43 | Re: [PATCH] PREPARE TRANSACTION unexpected behavior with TEMP TABLE |
| Previous Message | Peter Eisentraut | 2021-04-14 13:20:59 | Re: [PATCH] Identify LWLocks in tracepoints |