RE: Parallel INSERT SELECT take 2

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Greg Nancarrow <gregn4422(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: RE: Parallel INSERT SELECT take 2
Date: 2021-06-08 09:12:31
Message-ID: OS0PR01MB5716B25ADE37A765A1B76BFC94379@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

When testing the patch, I found some issues in the 0003,0004 patch.
Attaching new version patchset which fix these issues.

0003
* don't check parallel safety of partition's default column expression.
* rename some function/variable names to be consistent with existing code.
* remove some unused function parameters.
* fix a max_hazard overwrite issue.
* add some code comments and adjust some code forms.

0004
* Remove some unrelated comments in the regression test.
* add the 'begin;', 'rollback;' in insert_parallel.sql.

Best regards,
houzj

Attachment Content-Type Size
v9-0001-CREATE-ALTER-TABLE-PARALLEL-DML.patch application/octet-stream 42.1 KB
v9-0002-parallel-SELECT-for-INSERT.patch application/octet-stream 9.8 KB
v9-0003-get-parallel-safety-functions.patch application/octet-stream 29.6 KB
v9-0004-regression-test-and-doc-updates.patch application/octet-stream 101.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuro Yamada 2021-06-08 09:19:04 Re: Duplicate history file?
Previous Message Dilip Kumar 2021-06-08 08:47:06 Re: Race condition in recovery?