RE: row filtering for logical replication

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: row filtering for logical replication
Date: 2022-01-10 03:11:30
Message-ID: OS0PR01MB5716947AFA3AA29DAC6A9F0B94509@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Friday, January 7, 2022 11:50 AM Hou, Zhijie wrote:
> Attach the v60 patch set.
> Note that the 0004 patch is merged to 0001 patch.
>

Attach the v61 patch set.

Details
=======

V61-0001
- Remove the redundant coerce_to_target_type() in
pgoutput_row_filter_init_expr(). (Vignesh)
- Check no_filter before adding row filter to list(rfnodes). (Wangw [1])

V61-0002
(Peter's comments 1 ~ 6 except 1e from [2])
- remove unnecessary parens in pgoutput_row_filter
- update commit message
- update code comments
- remove unused function declaretion

V61-0003
- handle the Tab completion of "WITH(" in
"create publication pub1 for table t1 where (c1 > 10)": (Vignesh)

[1] https://www.postgresql.org/message-id/CAHut%2BPtzEjqfzdSvouNPm1E60qzzF%2BDS%3DwcocLLDvPYCpLXB9g%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CAHut%2BPvC7XFEJDFpEdaAneNUNv9Lo8O9SjEQyzUsBObrdkwTaw%40mail.gmail.com

Best regards,
Hou zj

Attachment Content-Type Size
v61-0003-Row-filter-tab-auto-complete-and-pgdump.patch application/octet-stream 5.8 KB
v61-0002-Row-filter-updates-based-on-old-new-tuples.patch application/octet-stream 45.4 KB
v61-0001-Row-filter-for-logical-replication.patch application/octet-stream 130.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message houzj.fnst@fujitsu.com 2022-01-10 03:16:39 RE: row filtering for logical replication
Previous Message Andres Freund 2022-01-10 02:55:02 Re: TAP test to cover "EndOfLogTLI != replayTLI" case