RE: Support logical replication of DDLs

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, Runqi Tian <runqidev(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, li jie <ggysxcq(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, rajesh singarapu <rajesh(dot)rs0541(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Zheng Li <zhengli10(at)gmail(dot)com>
Subject: RE: Support logical replication of DDLs
Date: 2023-04-07 03:12:49
Message-ID: OS0PR01MB57168840ABFAB9E9BB28A54B94969@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Tuesday, April 4, 2023 7:35 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Tue, Apr 4, 2023 at 8:43 AM houzj(dot)fnst(at)fujitsu(dot)com
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> > Attach the new version patch set which did the following changes:
> >
>
> Hello,
>
> I tried below:
> pubnew=# ALTER PUBLICATION mypub2 SET (ddl = 'table'); ALTER
> PUBLICATION
>
> pubnew=# \dRp+
> Publication mypub2 Owner | All tables
> | All DDLs | Table DDLs |
> --------+------------+----------+------------+---------
> shveta | t | f | f
> (1 row)
>
> I still see 'Table DDLs' as false and ddl replication did not work for this case.

Thanks for reporting.

Attach the new version patch which include the following changes:
* Fix the above bug for ALTER PUBLICATION SET.
* Modify the corresponding event trigger when user execute ALTER PUBLICATION SET to change the ddl option.
* Fix a miss in pg_dump's code which causes CFbot failure.
* Rebase the patch due to recent commit 4826759.

Best Regards,
Hou zj

Attachment Content-Type Size
0002-DDL-replication-for-Table-DDL-commands-2023_04_07.patch application/octet-stream 239.9 KB
0003-Deparser-for-INDEX-DDL-commands-2023_04_07.patch application/octet-stream 14.5 KB
0004-DDL-replication-for-index-DDL-commands-2023_04_07.patch application/octet-stream 77.3 KB
0005-Apply-the-DDL-change-as-that-same-user-th-2023_04_07.patch application/octet-stream 23.1 KB
0006-Deparser-and-DDL-replication-for-the-rest-2023_04_07.patch application/octet-stream 378.7 KB
0001-Deparser-for-Table-DDL-commands-and-exten-2023_04_07.patch application/octet-stream 158.1 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message houzj.fnst@fujitsu.com 2023-04-07 03:22:36 RE: Support logical replication of DDLs
Previous Message Louis Tian 2023-04-07 01:27:59 Re: [EXTERNAL]: Re: UPSERT in Postgres

Browse pgsql-hackers by date

  From Date Subject
Next Message Kirk Wolak 2023-04-07 03:13:03 Re: Schema variables - new implementation for Postgres 15
Previous Message Julien Rouhaud 2023-04-07 02:48:23 Re: [PoC] pg_upgrade: allow to upgrade publisher node