RE: row filtering for logical replication

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: row filtering for logical replication
Date: 2022-02-14 12:55:46
Message-ID: OS0PR01MB5716834CABD0F0E0D0FDBBEB94339@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Friday, February 11, 2022 5:02 PM houzj(dot)fnst(at)fujitsu(dot)com wrote:
>
> Attach the v81 patch which addressed above comments.

Attach the v82 patch which was rebased based on recent commit.

The new version patch also includes the following changes:

- disallow specifying row filter for partitioned table if pubviaroot is false.
Since only the partition's row filter would be used if pubviaroot is false,
so disallow this case to avoid confusion.
- some minor/cosmetic changes on comments, codes and testcases.
- un-comment the testcases for unchanged toast key.
- run pgindent and pgperltidy

Best regards,
Hou zj

Attachment Content-Type Size
v82-0001-Allow-specifying-row-filters-for-logical-replication.patch application/octet-stream 176.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-02-14 13:53:32 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Previous Message Amit Kapila 2022-02-14 11:58:02 Re: Optionally automatically disable logical replication subscriptions on error