RE: [BUG] Unexpected action when publishing partition tables

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Langote <amitlangote09(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: RE: [BUG] Unexpected action when publishing partition tables
Date: 2021-09-17 06:06:02
Message-ID: OS0PR01MB571638518960C60D0148DB2694DD9@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thursday, September 16, 2021 6:05 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> > On Tuesday, September 14, 2021 10:41 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > > On Tue, Sep 7, 2021 at 11:38 AM houzj(dot)fnst(at)fujitsu(dot)com <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > Thanks for the comment.
> > Attach new version patches which clean the table at the end.
> >
>
> + * For partitioned table contained in the publication, we must
> + * invalidate all partitions contained in the respective partition
> + * trees, not just the one explicitly mentioned in the publication.
>
> Can we slightly change the above comment as: "For the partitioned tables, we
> must invalidate all partitions contained in the respective partition hierarchies,
> not just the one explicitly mentioned in the publication. This is required
> because we implicitly publish the child tables when the parent table is
> published."
>
> Apart from this, the patch looks good to me.
>
> I think we need to back-patch this till v13. What do you think?

I agreed.

Attach patches for back-branch, each has passed regression tests and pgindent.

Best regards,
Hou zj

Attachment Content-Type Size
HEAD-Invalidate-all-partitions-for-partitioned-table-in-p.patch application/octet-stream 12.9 KB
PG14-Invalidate-all-partitions-for-partitioned-table-in-p.patch application/octet-stream 12.8 KB
PG13-Invalidate-all-partitions-for-partitioned-table-in-p.patch application/octet-stream 12.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2021-09-17 06:16:33 Re: improve pg_receivewal code
Previous Message Amit Kapila 2021-09-17 05:23:09 Re: relation OID in ReorderBufferToastReplace error message