RE: Parallel INSERT SELECT take 2

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Greg Nancarrow <gregn4422(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: RE: Parallel INSERT SELECT take 2
Date: 2021-06-10 01:26:38
Message-ID: OS0PR01MB57162736FF49E5D25A56F38C94359@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From: houzj(dot)fnst(at)fujitsu(dot)com <houzj(dot)fnst(at)fujitsu(dot)com>
> Hi,
>
> When testing the patch, I found some issues in the 0003,0004 patch.
> Attaching new version patchset which fix these issues.
>
> 0003
> * don't check parallel safety of partition's default column expression.
> * rename some function/variable names to be consistent with existing code.
> * remove some unused function parameters.
> * fix a max_hazard overwrite issue.
> * add some code comments and adjust some code forms.
>
> 0004
> * Remove some unrelated comments in the regression test.
> * add the 'begin;', 'rollback;' in insert_parallel.sql.

Through further review and thanks for greg-san's suggestions,
I attached a new version patchset with some minor change in 0001,0003 and 0004.

0001.
* fix a typo in variable name.
* add a TODO in patch comment about updating the version number when branch PG15.

0003
* fix a 'git apply white space' warning.
* Remove some unnecessary if condition.
* add some code comments above the safety check function.
* Fix some typo.

0004
* add a testcase to test ALTER PARALLEL DML UNSAFE/RESTRICTED.

Best regards,
houzj

Attachment Content-Type Size
v10-0001-CREATE-ALTER-TABLE-PARALLEL-DML.patch application/octet-stream 42.3 KB
v10-0002-parallel-SELECT-for-INSERT.patch application/octet-stream 9.8 KB
v10-0003-get-parallel-safety-functions.patch application/octet-stream 30.3 KB
v10-0004-regression-test-and-doc-updates.patch application/octet-stream 102.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-06-10 01:32:30 Re: please update ps display for recovery checkpoint
Previous Message John Naylor 2021-06-10 01:21:10 a path towards replacing GEQO with something better