| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | RE: Perform streaming logical transactions by background workers and parallel apply |
| Date: | 2023-01-31 03:34:37 |
| Message-ID: | OS0PR01MB571621A51D40CA3DE45E6E0694D09@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, January 30, 2023 10:20 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
>
> I have one comment on v89 patch:
>
> + /*
> + * Using 'immediate' mode returns false to cause a switch to
> + * PARTIAL_SERIALIZE mode so that the remaining changes will
> be serialized.
> + */
> + if (logical_replication_mode == LOGICAL_REP_MODE_IMMEDIATE)
> + return false;
> +
>
> Probably we might want to add unlikely() here since we could pass through this
> path very frequently?
I think your comment makes sense, thanks.
I updated the patch for the same.
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v90-0001-Extend-the-logical_replication_mode-to-test-the-.patch | application/octet-stream | 14.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2023-01-31 03:34:45 | RE: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | Justin Pryzby | 2023-01-31 02:43:20 | Re: Scan buffercache for a table |