| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | RE: Synchronizing slots from primary to standby |
| Date: | 2024-01-22 08:49:11 |
| Message-ID: | OS0PR01MB57160C7184E17C6765AAE38294752@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, January 22, 2024 11:36 AM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
Hi,
> On Fri, Jan 19, 2024 at 4:18 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> >
> > PFA v64.
>
> V64 fails to apply to HEAD due to a recent commit. Rebased it. PFA v64_2. It has
> no new changes.
I noticed few things while analyzing the patch.
1.
sleep_ms = Min(sleep_ms * 2, MAX_WORKER_NAPTIME_MS);
The initial value for sleep_ms is 0(default value for static variable) which
will not be advanced in this expression. We should initialize sleep_ms to a positive
number.
2.
/ Wait a bit, we don't expect to have to wait long /
rc = WaitLatch(MyLatch,
WL_LATCH_SET | WL_TIMEOUT | WL_EXIT_ON_PM_DEATH,
10L, WAIT_EVENT_BGWORKER_SHUTDOWN);
The slotsync worker is not a bgworker anymore after 0003 patch, so a new event
is needed I think.
3.
slot->effective_catalog_xmin = xmin_horizon;
The assignment is also needed in local_slot_update() to make
ReplicationSlotsComputeRequiredXmin work.
Best Regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2024-01-22 09:07:45 | Re: Test slots invalidations in 035_standby_logical_decoding.pl only if dead rows are removed |
| Previous Message | Michael Paquier | 2024-01-22 08:38:13 | Re: heavily contended lwlocks with long wait queues scale badly |