RE: row filtering for logical replication

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: row filtering for logical replication
Date: 2022-01-07 03:49:49
Message-ID: OS0PR01MB571600F2D2D2962D6C9F9754944D9@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thursday, January 6, 2022 8:10 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> On Thu, Jan 6, 2022 at 9:29 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > FYI - v58 is currently known to be broken due to a recent commit [1].
> >
> > I plan to post a v59* later today to address this as well as other
> > recent review comments.
>
>
> Here is the v59* patch set:

Attach the v60 patch set.
Note that the 0004 patch is merged to 0001 patch.

Details
=======

V60-0001
- Skip the transformation if where clause is not specified (Amit[1])
- Change the return type of transformPubWhereClauses to "void" (Amit[1])
- Merge 0004 patch to 0001 patch (Vignesh [2])
- Remove unnecessary includes (Vignesh [2])
- Add an Assert for a valid value of relation->rd_pubactions before doing memcpy
in GetRelationPublicationActions() and add some comments atop
GetRelationPublicationInfo () (Amit [3])

V60-0002 (new/old tuple)
V60-0003 (tab, dump)
- no change

[1] https://www.postgresql.org/message-id/CAA4eK1Ky0z%3D%2BUznCUHOs--L%3DEs_EMmZ_rxNo8FH73%3D758sahsQ%40mail.gmail.com
[2] https://www.postgresql.org/message-id/CALDaNm13yVPH0EcObv4tCHLQfUwjfvPFh8c-nd3Ldg71Y9es7A%40mail.gmail.com
[3] https://www.postgresql.org/message-id/CAA4eK1JgcNtmurzuTNw%3DFcNoJcODobx-y0FmohVQAce0-iitCA%40mail.gmail.com

Best regards,
Hou zj

Attachment Content-Type Size
v60-0002-Row-filter-updates-based-on-old-new-tuples.patch application/octet-stream 45.5 KB
v60-0003-Row-filter-tab-auto-complete-and-pgdump.patch application/octet-stream 5.6 KB
v60-0001-Row-filter-for-logical-replication.patch application/octet-stream 131.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Takashi Menjo 2022-01-07 03:50:01 Re: Map WAL segment files on PMEM as WAL buffers
Previous Message Bharath Rupireddy 2022-01-07 03:37:35 Re: Deduplicate min restart_lsn calculation code