Re: Add LZ4 compression in pg_dump

From: gkokolatos(at)pm(dot)me
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Rachel Heaton <rachelmheaton(at)gmail(dot)com>
Subject: Re: Add LZ4 compression in pg_dump
Date: 2022-11-28 16:32:43
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

------- Original Message -------
On Tuesday, November 22nd, 2022 at 11:49 AM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> On Tue, Nov 22, 2022 at 10:00:47AM +0000, gkokolatos(at)pm(dot)me wrote:
> > A new version that I feel that is in a decent enough state for review should
> > be ready within this week. I am happy to drop the patch if you think I should
> > not work on it though.
> If you can post a new version of the patch, that's fine, of course.
> I'll be happy to look over it more.

Thank you Michael (and Justin). Allow me to present v8.

The focus of this version of this series is 0001 and 0002.

Admittedly 0001 could be presented in a separate thread though given its size and
proximity to the topic, I present it here.

In an earlier review you spotted the similarity between pg_dump's and pg_receivewal's
parsing of compression options. However there exists a substantial difference in the
behaviour of the two programs; one treats the lack of support for the requested
algorithm as a fatal error, whereas the other does not. The existing functions in
common/compression.c do not account for the later. 0002 proposes an implementation
for this. It's usefulness is shown in 0003.

Please consider 0003-0005 as work in progress. They are differences from v7 yet they
may contain unaddressed comments for now.

A welcome feedback would be in splitting and/or reordering of 0003-0005. I think
that they now split in coherent units and are presented in a logical order. Let me
know if you disagree and where should the breakpoints be.


> --
> Michael

Attachment Content-Type Size
v8-0003-Prepare-pg_dump-for-additional-compression-method.patch text/x-patch 50.5 KB
v8-0001-Export-gzip-program-to-pg_dump-tap-tests.patch text/x-patch 658 bytes
v8-0002-Make-the-pg_receivewal-compression-parsing-functi.patch text/x-patch 10.0 KB
v8-0004-Introduce-Compressor-API-in-pg_dump.patch text/x-patch 53.9 KB
v8-0005-Add-LZ4-compression-in-pg_-dump-restore.patch text/x-patch 28.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-11-28 16:39:22 Re: Removing another special case
Previous Message Peter Eisentraut 2022-11-28 16:25:13 Re: Removing another special case