| From: | Lucas DRAESCHER <git(at)draescher(dot)fr> |
|---|---|
| To: | cca5507 <cca5507(at)qq(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [Bug Report + Patch] File descriptor leak when io_method=io_uring |
| Date: | 2026-03-27 16:57:42 |
| Message-ID: | MVJo_s9NkLXQ1QYpxH_bTSHPX81pV_6BTv8Tmgs0AlU13rdxnhxh-9EWQoNXPeAqJ7TwXqA-L1x7dZuaRnZDwkIrcE7X9nrTtJdTF6z32xk=@draescher.fr |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi ChangAo,
Thanks for the review!
I've attached v2, which adds a shmem_cleanup callback to
IoMethodOps, registered in AioShmemInit().
Like you, I don't know which approach I prefer since the
new callback currently has only one implementor. If no
other IO method is expected to need cleanup, the simpler
v1 approach may be preferable. Happy to hear your thoughts.
I've also added this patch to the commitfest app:
https://commitfest.postgresql.org/patch/6617/
Regards,
Lucas.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Release-io_uring-resources-on-shmem-exit.patch | text/x-patch | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2026-03-27 17:01:09 | Re: Adding REPACK [concurrently] |
| Previous Message | Sami Imseih | 2026-03-27 16:48:27 | Re: Track skipped tables during autovacuum and autoanalyze |