| From: | japin <japinli(at)hotmail(dot)com> |
|---|---|
| To: | "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "bharath(dot)rupireddyforpostgres(at)gmail(dot)com" <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Terminate the idle sessions |
| Date: | 2020-11-19 09:35:05 |
| Message-ID: | MEYP282MB16699F819074254A35F2AE07B6E00@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
hi, Kuroda
On 11/19/20 4:32 PM, kuroda(dot)hayato(at)fujitsu(dot)com wrote:
> Dear Li,
>
>> Thanks for your suggestion. Attached!
> I prefer your comments:-).
>
> I think this patch is mostly good.
> I looked whole the codes again and I found the following comment in the PostgresMain():
>
> ```c
> /*
> * (5) turn off the idle-in-transaction timeout
> */
> ```
>
> Please mention about idle-session timeout and check another comment.
Thanks! Add the comment for idle-session timeout.
--
Best regards
Japin Li
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Allow-terminating-the-idle-sessions.patch | text/x-patch | 10.4 KB |
| v8-0002-Optimize-setitimer-usage.patch | text/x-patch | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2020-11-19 09:36:26 | Re: Sloppiness around failure handling of parsePGArray in pg_dump |
| Previous Message | Julien Rouhaud | 2020-11-19 09:27:18 | Re: ResourceOwner refactoring |