Re: Support ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION ... syntax

Thanks for your review again.

On Wed, 10 Feb 2021 at 21:49, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> On Fri, Feb 5, 2021 at 6:51 PM japin <japinli(at)hotmail(dot)com> wrote:
>> On Fri, 05 Feb 2021 at 17:50, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>> We will get cell == NULL when we iterate all items in publist. I use it
>> to check whether the dropped publication is in publist or not.
>>
>> > If you
>> > have a strong reasong retain this error errmsg("publication name
>> > \"%s\" do not in subscription", then there's a typo
>> > errmsg("publication name \"%s\" does not exists in subscription".
>>
>> Fixed.
>
> I think we still have a typo in 0002, it's
> + errmsg("publication name \"%s\" does not exist
> in subscription",
> instead of
> + errmsg("publication name \"%s\" does not exists
> in subscription",
>

Fixed.

> IIUC, with the current patch, the new ALTER SUBSCRIPTION ... ADD/DROP
> errors out on the first publication that already exists/that doesn't
> exist right? What if there are multiple publications given in the
> ADD/DROP list, and few of them exist/don't exist. Isn't it good if we
> loop over the subscription's publication list and show all the already
> existing/not existing publications in the error message, instead of
> just erroring out for the first existing/not existing publication?
>

Yes, you are right. Agree with you, I modified it. Please consider v5
for further review.

--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.