Re: Pasword expiration warning

From: Japin Li <japinli(at)hotmail(dot)com>
To: Steven Niu <niushiji(at)gmail(dot)com>
Cc: Yuefei Shi <shiyuefei1004(at)gmail(dot)com>, Gilles Darold <gilles(at)darold(dot)net>, songjinzhou <tsinghualucky912(at)foxmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, liu xiaohui <liuxh(dot)zj(dot)cn(at)gmail(dot)com>
Subject: Re: Pasword expiration warning
Date: 2026-01-09 09:04:31
Message-ID: MEAPR01MB30319C7BB75B88028E1DB7E1B682A@MEAPR01MB3031.ausprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hi, Steven

Thanks for the review.

On Fri, 09 Jan 2026 at 07:36, Steven Niu <niushiji(at)gmail(dot)com> wrote:
> Hi, Jiapin,
>
> I reviewed the v9-0002-Add-TAP-test-for-password_expire_warning.patch
> and here are my comments:
>
> 1. I think we should add tow more cases. One case is for the feature is disbaled. And another is for no warning when >1d remaining.

Add in v10.

> 2. The modification to pg_hba.conf is unnecessary as the default pg_hba.conf generated by initdb already allows local connections with appropriate methods.
> unlink($node->data_dir . '/pg_hba.conf');
> $node->append_conf('pg_hba.conf', "local all all scram-sha-256");

Yes, it allows local connections, but they are always in trust mode, so no
password is required (or used).

> 3. Make the expected string to be more exact.
> qr/your password will expire in/);
> -->
> qr/your password will expire in 1d/);
>

Fixed. PFA.

v10-0001 - No changes.
v10-0002 - Address review comments.

--
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.

Attachment Content-Type Size
v10-0001-Add-password_expire_warning-GUC-to-warn-clients.patch text/x-diff 7.8 KB
v10-0002-Add-TAP-test-for-password_expire_warning.patch text/x-diff 2.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2026-01-09 09:35:11 Re: Import Statistics in postgres_fdw before resorting to sampling.
Previous Message Amit Kapila 2026-01-09 09:00:47 Re: [Patch] add new parameter to pg_replication_origin_session_setup