| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Switching XLog source from archive to streaming when primary available |
| Date: | 2024-02-20 06:24:49 |
| Message-ID: | ME3P282MB3166D3391A9FC11DD35C05D9B6502@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 20 Feb 2024 at 13:40, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> On Mon, Feb 19, 2024 at 8:25 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
>> [2]
>> +# Ensure checkpoint doesn't come in our way
>> +$primary->append_conf('postgresql.conf', qq(
>> + min_wal_size = 2MB
>> + max_wal_size = 1GB
>> + checkpoint_timeout = 1h
>> + autovacuum = off
>> +));
>>
>> Keeping the same indentation might be better.
>
> The autovacuum line looks mis-indented in the patch file. However, I
> now ran src/tools/pgindent/perltidyrc
> src/test/recovery/t/041_wal_source_switch.pl on it.
>
Thanks for updating the patch. It seems still with the wrong indent.
| Attachment | Content-Type | Size |
|---|---|---|
| fix-indent.patch | text/x-diff | 820 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2024-02-20 06:30:36 | Re: Patch: Add parse_type Function |
| Previous Message | Andy Fan | 2024-02-20 06:20:36 | Re: Shared detoast Datum proposal |