| From: | gkokolatos(at)pm(dot)me |
|---|---|
| To: | Jian Guo <gjian(at)vmware(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Teach pg_receivewal to use lz4 compression |
| Date: | 2021-09-13 08:35:43 |
| Message-ID: | LLkX3RHsODZzyAJI033ZsLqPxDKHYhQANy6hweFCN_YEO5lndNYL5idWqGDYzyU6g5OA0BNdZO2n_nE99w5wQLvWRWFTuzINBjjvT7v11Wg=@pm.me |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Saturday, September 11th, 2021 at 07:02, Jian Guo <gjian(at)vmware(dot)com> wrote:
Hi,
thank you for looking at the patch.
> - LZ4F_decompressionContext_t ctx = NULL;
> - snprintf(fullpath, sizeof(fullpath), "%s/%s", basedir, dirent->d_name);
> - fd = open(fullpath, O_RDONLY | PG_BINARY, 0);
>
> Should close the fd before exit or abort.
You are correct. Please find version 4 attached.
Cheers,
//Georgios
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Teach-pg_receivewal-to-use-lz4-compression.patch | application/octet-stream | 32.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-09-13 08:36:29 | Re: drop tablespace failed when location contains .. on win32 |
| Previous Message | Kyotaro Horiguchi | 2021-09-13 08:21:31 | Re: corruption of WAL page header is never reported |