Add FOREIGN to ALTER TABLE in pg_dump

From: Luis Carril <luis(dot)carril(at)swarm64(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Add FOREIGN to ALTER TABLE in pg_dump
Date: 2019-07-12 12:02:37
Message-ID: LEJPR01MB0185A19B2E7C98E5E2A031F5E7F20@LEJPR01MB0185.DEUPRD01.PROD.OUTLOOK.DE
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,
pg_dump creates plain ALTER TABLE statements even if the table is a foreign table, which for someone reading the dump is confusing.
This also made a difference when applying the dump if there is any plugin installed that hooks on ProcessUtility, because the plugin could react differently to ALTER TABLE than to ALTER FOREIGN TABLE. Opinions?

An unrelated question: if I apply pgindent to a file (in this case pg_dump.c) and get a bunch of changes on the indentation that are not related to my patch, which is the accepted policy? A different patch first with only the indentation? Maybe, am I using pgindent wrong?

Cheers
Luis M Carril

Attachment Content-Type Size
0001-Add-FOREIGN-to-ALTER-statements.patch text/x-patch 7.1 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message Eugen Konkov 2019-07-12 12:27:46 Re: Request for improvement: Allow to push (t.o).id via GROUP BY ocd.o
Previous Message Pavel Stehule 2019-07-12 12:00:25 Re: Check-out mutable functions in check constraints