Re: Include access method in listTables output

From: Georgios <gkokolatos(at)protonmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, David Rowley <dgrowleyml(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Include access method in listTables output
Date: 2020-07-16 14:05:52
Message-ID: IAAkZPMD4wrhBRGTawUn2xmwD7IFqrRNTipE4IglRS6zgzLLWyLIR4TuwrLXQolL89Vh7KPVMlJ2xNlSY4SstnJOwDif4vQxJar-XWU6Soc=@protonmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Saturday, July 11, 2020 3:16 PM, vignesh C <vignesh21(at)gmail(dot)com> wrote:

> On Mon, Jul 6, 2020 at 1:24 PM Georgios gkokolatos(at)protonmail(dot)com wrote:
>
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> > On Monday, July 6, 2020 3:12 AM, Michael Paquier michael(at)paquier(dot)xyz wrote:
> >
> > > On Sun, Jul 05, 2020 at 07:13:10AM +0530, vignesh C wrote:
> > >
> > > > I'm not sure if we should include showViews, I had seen that the
> > > > access method was not getting selected for view.
> > >
> > > +1. These have no physical storage, so you are looking here for
> > > relkinds that satisfy RELKIND_HAS_STORAGE().
> >
> > Thank you for the review.
> > Find attached v4 of the patch.
>
> Thanks for fixing the comments.
> Patch applies cleanly, make check & make check-world passes.
> I was not sure if any documentation change is required or not for this
> in doc/src/sgml/ref/psql-ref.sgml. Thoughts?
>

Thank you for the comment. I added a line in docs. Admittedly, might need tweaking.

Please find version 5 of the patch attached.

> Regards,
> Vignesh
> EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
0001-Include-AM-in-listTables-output-v5.patch application/octet-stream 8.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2020-07-16 14:14:40 Re: [PATCH] Performance Improvement For Copy From Binary Files
Previous Message Robert Haas 2020-07-16 14:00:40 Re: recovering from "found xmin ... from before relfrozenxid ..."