check_function_bodies: At least the description seems wrong, since we have prodedures

From: "Daniel Westermann (DWE)" <daniel(dot)westermann(at)dbi-services(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: check_function_bodies: At least the description seems wrong, since we have prodedures
Date: 2021-04-09 12:11:35
Message-ID: GV0P278MB04834A9EB9A74B036DC7CE49D2739@GV0P278MB0483.CHEP278.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

check_function_bodies has this description:

postgres=# select short_desc from pg_settings where name = 'check_function_bodies';
short_desc
-----------------------------------------------
Check function bodies during CREATE FUNCTION.
(1 row)

This is not the whole truth since we have procedures, as this affects CREATE PROCEDURE as well:

postgres=# create procedure p1 ( a int ) as $$ beginn null; end $$ language plpgsql;
ERROR: syntax error at or near "beginn"
LINE 1: create procedure p1 ( a int ) as $$ beginn null; end $$ lang...
^
postgres=# set check_function_bodies = false;
SET
postgres=# create procedure p1 ( a int ) as $$ beginn null; end $$ language plpgsql;
CREATE PROCEDURE
postgres=#

At least the description should mention procedures. Even the parameter name seems not to be correct anymore. Thoughts?

Regards
Daniel

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chapman Flack 2021-04-09 13:21:42 Re: check_function_bodies: At least the description seems wrong, since we have prodedures
Previous Message David Steele 2021-04-09 11:54:29 Re: SQL:2011 PERIODS vs Postgres Ranges?