Re: Include access method in listTables output

From: Georgios <gkokolatos(at)protonmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Rowley <dgrowleyml(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Include access method in listTables output
Date: 2020-08-20 08:16:19
Message-ID: G0lbTP5dhDHUcVItcS-RKH-IjELjZ0_51WHKGQLjdfaw-PVIm-1asVAYUYuEflnQk_5cbRIjirvZm24QAE6LKaZTsza_xWQF8VvsuzBBNYg=@protonmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, 20 August 2020 07:31, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:

> On Mon, Aug 17, 2020 at 11:10:05PM +0530, vignesh C wrote:
>
> > On Sat, Aug 1, 2020 at 8:12 AM vignesh C vignesh21(at)gmail(dot)com wrote:
> >
> > > > > +-- access method column should not be displayed for sequences
> > > > > +\ds+
> > > > >
> > > > > - List of relations
> > > > >
> > > > >
> > > > > - Schema | Name | Type | Owner | Persistence | Size | Description
> > > > > +--------+------+------+-------+-------------+------+-------------
> > > > > +(0 rows)
> > > > > We can include one test for view.
> > > > >
> >
> > I felt adding one test for view is good and added it.
> > Attached a new patch for the same.
> > I felt patch is in shape for committer to have a look at this.
>
> The patch tester shows it's failing xmllint ; could you send a fixed patch ?
>
> /usr/bin/xmllint --path . --noout --valid postgres.sgml
> ref/psql-ref.sgml:1189: parser error : Opening and ending tag mismatch: link line 1187 and para
>
> http://cfbot.cputube.org/georgios-kokolatos.html

Thank you for pointing it out!

Please find version 7 attached which hopefully addresses the error along with a proper
expansion of the test coverage and removal of recently introduced
whitespace warnings.

>
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Justin

Attachment Content-Type Size
0001-Include-access-method-in-listTables-output-v7.patch application/octet-stream 12.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2020-08-20 08:18:07 Re: "ccold" left by reindex concurrently are droppable?
Previous Message Dilip Kumar 2020-08-20 08:10:45 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions