Skip site navigation (1) Skip section navigation (2)

Re: First DataTable submission to CVS!!

From: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
To: "'pgsql(at)timfinch(dot)cix(dot)co(dot)uk'" <pgsql(at)timfinch(dot)cix(dot)co(dot)uk>,pgadmin-hackers(at)postgresql(dot)org
Subject: Re: First DataTable submission to CVS!!
Date: 2002-03-18 21:05:07
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgadmin-hackers

> -----Original Message-----
> From: pgsql(at)timfinch(dot)cix(dot)co(dot)uk [mailto:pgsql(at)timfinch(dot)cix(dot)co(dot)uk] 
> Sent: 18 March 2002 18:20
> To: pgadmin-hackers(at)postgresql(dot)org
> Subject: [pgadmin-hackers] First DataTable submission to CVS!!
> Dave, Jean-Michel, Mark,
> I have submitted my first bunch of early alpha files of 
> DataTable OCX to 
> the CVS in /dev/DataTable
> There is a readme that tells you what to do. Its not 
> fantastic but at least 
> is the start of the control.
> My idea is to keep the DataTable.ocx control totally unaware 
> of PostgreSQL 
> or pgSchema, and simply set simple
> properties and use methods to set it up.

Yup, sounds good.

> The second control that Mark asked me to work on (the Diagram 
> Pane) will be 
> pgSchema aware and will translate what it sees in a pgSchema 
> table or View 
> object and set the necessary properties on the DataTable ocx 
> when one is 
> being set up in the diagramming pane.


> I am also aware that the coding style does not match your 
> requested method 
> of working Dave yet.

It's not far out. Controls can't really have all the logging/error handling
that everything else does so you really need to make them bombproof. My main
concerns will be (in the future, when your looking to integrate the code),
object/variable naming, consistant indenting (2 char), and licence the
> Look forward to feedback.
> Tim.

1) Check the spelling of dtbFieldConstraint's values before you write too
much code around them.
2) I don't like the italic/underline. I think plain for regular fields, and
bold + a colour for fkey/pkeys etc.
3) Use of only 3 datatypes is not good. It should support any (including
custom) types, as does the rest of pgSchema/pgAdmin. Of course, this will
make the box bigger, but I think it's a must.

Looks pretty good though. You might want to drop email to Mark
(myeatman(at)put(dot)my(dot)domain(dot)here) he's the 3rd core developer but is usually
very quiet. He's been working on a similar sort of control on and off for
some time to represent a node on a network in a network mapping extension to
some other software we write. It strikes me that there will be  many
similarities between the code in his and your controls, especially when it
comes to drawing & tracking many of them and drawing links between them.

Regards, Dave.

pgadmin-hackers by date

Next:From: Dave PageDate: 2002-03-18 22:08:29
Subject: Re: WinCVS...uuurggh
Previous:From: Dave PageDate: 2002-03-18 20:42:48
Subject: Re: idea for show connection user

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group