Skip site navigation (1) Skip section navigation (2)


From: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
To: "'jm(dot)poure(at)freesurf(dot)fr'" <jm(dot)poure(at)freesurf(dot)fr>,pgadmin-hackers(at)postgresql(dot)org
Date: 2002-02-22 22:06:52
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgadmin-hackers
Hi Jean-Michel,

I just took a look at the latest ALTER VIEW code. Sorry, but I have a number
of problems with this version:

1) Don't create the view twice, create the fake one then rename it - it's
less expensive and avoids the potential for the second create to fail.

2) The szOldDefintion stuff can now be removed.

3) The OID and Definition could be retrieved in one operation rather than 2.

4) A class library such as this should _never_ display any user interface.
That is the job of the application.

5) The modifications to the SQL property are messy & mainly unnecessary
(certainly with #1 above - that just needs bDrop & szViewName).

6) The iLogEvent "Entering..." code should be immediately after the On Error
code, not in the middle of the function.

7) The Comment cache is not being invalidated.

Regards, Dave.


pgadmin-hackers by date

Next:From: Jean-Michel POUREDate: 2002-02-22 22:11:21
Subject: Re: ALTER VIEW
Previous:From: Jean-Michel POUREDate: 2002-02-22 22:06:36
Subject: Triggers

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group