Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions?

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Ought to use heap_multi_insert() for pg_attribute/depend insertions?
Date: 2019-08-05 07:20:07
Message-ID: FDE9489D-05A8-4A51-9BBA-B156B4D1BABE@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 2 Aug 2019, at 00:41, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> On Tue, Jul 9, 2019 at 11:07 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> The attached v3 also has that fix in order to see if the cfbot is happier with
>> this.
>
> Noticed while moving this to the next CF:
>
> heap.c: In function ‘StorePartitionKey’:
> 1191heap.c:3582:3: error: ‘referenced’ undeclared (first use in this function)
> 1192 referenced.classId = RelationRelationId;
> 1193 ^

Thanks, the attached v4 updates to patch to handle a0555ddab9b672a046 as well.

cheers ./daniel

Attachment Content-Type Size
catalog_multi_insert-v4.patch application/octet-stream 44.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-08-05 07:26:25 Re: pglz performance
Previous Message Michael Paquier 2019-08-05 07:04:46 Re: pglz performance