| From: | Roma Sokolov <sokolov(dot)r(dot)v(at)gmail(dot)com> |
|---|---|
| To: | Euler Taveira <euler(at)timbira(dot)com(dot)br> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Женя Зайцев <zevlg(at)yandex(dot)ru> |
| Subject: | Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator |
| Date: | 2016-02-26 20:51:03 |
| Message-ID: | F91420DD-0209-44EA-AB37-B22F641EC943@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for comments, Euler!
> ... is hard to understand. Instead, you could separate the conditional
> expression into a variable.
Fixed the patch to be more descriptive and to avoid repeating same
computation over and over again. See v2 of the patch attached.
> I don't think those are mandatory.
Why do you think that? Should I remove them or maybe send as separate
patch?
Cheers,
Roma
| Attachment | Content-Type | Size |
|---|---|---|
| fix_drop_operator_reset_oprcom_and_oprnegate_fields_v2.patch | application/octet-stream | 17.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-02-26 22:37:54 | Re: [REVIEW] In-core regression tests for replication, cascading, archiving, PITR, etc. |
| Previous Message | Konstantin Knizhnik | 2016-02-26 20:19:11 | Re: The plan for FDW-based sharding |